[Freecol-developers] Latest Git cannot load saved game

[Caleb Williams]

Hey all:

I just compiled the latest Git revision ([169c8a
<https://sourceforge.net/p/freecol/git/ci/169c8af7534b7e0f54c150842b1fdbe1cddfcafb/>])
and
found I could not load a saved game file I had previously been able to load.

I think this may be an issue with revision [169c8a
<https://sourceforge.net/p/freecol/git/ci/169c8af7534b7e0f54c150842b1fdbe1cddfcafb/>],
as I had earlier compiled either [ba2953
<https://sourceforge.net/p/freecol/git/ci/ba295349f207fb1a2b3e0576569241783e316b57/>]
or [29651c
<https://sourceforge.net/p/freecol/git/ci/29651c97ff17d827bbeb30852f9f660cda4d0ada/>],
and that loaded the same saved game just fine.

Error message: "The server can not read the saved game."

Log attached. FSG file attached as well.

Best,

--
*Caleb R. Williams*

[w***@genial.ms]

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF

[Caleb Williams]

On Sat, Apr 11, 2015 at 3:23 PM, <***@genial.ms> wrote:

> Hi,
>
> thats weird, cause it seems to be the same file you sent me once for
> trying the dialog change
> and I was constantly using it today for checking the game runs well.
> I also did not change anything on the xml-reader which is producing the
> exceptions in your log.
> Can you try typing "ant distclean" into the commandline ant then rebuild
> and retest, because
> for me that save works with latest commit?
>
>
> Greetings,
>
> wintertime
>

I did just as you asked, ran "ant clean" and "ant distclean" and then
recompiled [27aa48], and I still cannot load that file.

I wonder if it became corrupted with one of the recent changes, because I
am able to load other saved game files correctly.

When I looked at what you had done, I didn't think that was the issue, but
I wasn't sure if somehow some of your changes did something I wasn't
familiar with.

Puzzling.

- Caleb

--
*Caleb R. Williams*

[Michael T. Pope]

On Sat, 11 Apr 2015 15:33:35 -0500
Caleb Williams <***@gmail.com> wrote:
> I did just as you asked, ran "ant clean" and "ant distclean" and then
> recompiled [27aa48], and I still cannot load that file.

I can not reproduce a problem either. The game loads fine for me, and if
I unpack it and look at the point it goes wrong according to the crash in
the log file, it also looks normal/not-corrupt.

I added some more tracing in git.b542f46, that may shed further light
on the problem.

Cheers,
Mike Pope

[Jonathan Aquilina]

Could it be something with the code he had pulled in his system. I would
also suggest a clean clone of the code from git to see if there is really a
problem in the codebase to begin with.

On Sun, Apr 12, 2015 at 8:47 AM, Michael T. Pope <***@computer.org> wrote:

> On Sat, 11 Apr 2015 15:33:35 -0500
> Caleb Williams <***@gmail.com> wrote:
> > I did just as you asked, ran "ant clean" and "ant distclean" and then
> > recompiled [27aa48], and I still cannot load that file.
>
> I can not reproduce a problem either. The game loads fine for me, and if
> I unpack it and look at the point it goes wrong according to the crash in
> the log file, it also looks normal/not-corrupt.
>
> I added some more tracing in git.b542f46, that may shed further light
> on the problem.
>
> Cheers,
> Mike Pope
>
>
> ------------------------------------------------------------------------------
> BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
> Develop your own process in accordance with the BPMN 2 standard
> Learn Process modeling best practices with Bonita BPM through live
> exercises
> http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual-
> event?utm_
> source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
> _______________________________________________
> Freecol-developers mailing list
> Freecol-***@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freecol-developers
>
>


--
Jonathan Aquilina

[w***@genial.ms]

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF

[Caleb Williams]

On Sun, Apr 12, 2015 at 1:47 AM, Michael T. Pope <***@computer.org> wrote:

> On Sat, 11 Apr 2015 15:33:35 -0500
> Caleb Williams <***@gmail.com> wrote:
> > I did just as you asked, ran "ant clean" and "ant distclean" and then
> > recompiled [27aa48], and I still cannot load that file.
>
> I can not reproduce a problem either. The game loads fine for me, and if
> I unpack it and look at the point it goes wrong according to the crash in
> the log file, it also looks normal/not-corrupt.
>
> I added some more tracing in git.b542f46, that may shed further light
> on the problem.
>
> Cheers,
> Mike Pope
>

Hey all:

It is certainly possible there was some localized corruption. It's even
possible that FreeCol was able to fix the corruption itself, but whatever
happened seems to now be fixed.

I compiled a clean download of [980453
<https://sourceforge.net/p/freecol/git/ci/98045344928a0b62394a5139a6e27c6d5da63721/>]
and while some files failed to load on the first go around, loading the
same file again fixed it and that file loaded.

I also redownloaded the attached saved game file and was able to load that
with no issue.

Also, used Git Extensions to update the code base as well and recompiled
there, and that works.

Glad this wasn't anything more serious.

Best,

--
*Caleb R. Williams*