[Freecol-developers] Claiming Tickets #43 & #199 Improvement Requests

[Dong Kim]

Hello FreeCol developers,

My team and I are working on contributing to an open source project as part
of our class, and we wanted to claim tickets #43 and #199 for Improvement
Requests:

#199 Hotkey for move all goods:
https://sourceforge.net/p/freecol/improvement-requests/199/
#43 Display selling price when trading:
https://sourceforge.net/p/freecol/improvement-requests/43/

In addition, we had a few questions regarding ticket #43- which are
the relevant GUI elements that need EU pricing details on goods displayed?
We've encountered just the trade windows with the natives so far, and were
wondering how many other panels/dialogues we'd be working with, and if
there are any specific classes we should be looking at.

Please let us know at your earliest convenience. Thank you!

[Michael T. Pope]

On Tue, 22 Nov 2016 15:53:38 -0500

Post by Dong Kim
My team and I are working on contributing to an open source project as part
of our class, and we wanted to claim tickets #43 and #199 for Improvement

No problem. Go for it.

Post by Dong Kim
In addition, we had a few questions regarding ticket #43- which are
the relevant GUI elements that need EU pricing details on goods displayed?
We've encountered just the trade windows with the natives so far,

That would be the main one where a player may reasonably be wondering
whether it is better to sell some goods in Europe.

Post by Dong Kim
and were
wondering how many other panels/dialogues we'd be working with, and if
there are any specific classes we should be looking at.

The only other case would be when trading with European colonies. That
is in NegotiationDialog. That is one of the nastiest pieces of the GUI.
Good luck if you venture in there!

Cheers,
Mike Pope

[Caleb Williams]

Post by Dong Kim
and were
wondering how many other panels/dialogues we'd be working with, and if
there are any specific classes we should be looking at.

... That is in NegotiationDialog. ...

As Mike said, nasty. Please let me know if you need any doc improvements to
the panel's layout details. (Or any others for that matter.) I don't think
I ever did a panel layout for that dialog.

If there are others that you need assistance, please let us know.

-Caleb Williams

[Caleb Williams]

Kim,

For posterity, please include the main developer mailing list in all
non-sensitive discussions.

Generally speaking new contributors are required to fork the FreeCol
repository and submit a pull request or even a patch via the SourceForge UI.
The developer guide LaTeX file is available at https://sourceforge.net/p/
freecol/git/ci/master/tree/doc/developer.tex though I don't know if there a
PDF available of the most current version. You may need to create the PDF.

Once established, users are often given read/write access by a project
administrator, most likely Mike Pope. I would assume that all of your
students are going to sign up for an SF account so that `git blame` works
properly.

Hopefully Mike will chime in if he has a better way to manage a new group
of contributors. My opinion is that the more help, the better. The more
sets of eyes, the more potential fixes can be added to the code base.

Thanks,

- Caleb

Hi Caleb,
Yes I received it, thanks a lot! Also I have another question- how do we
push changes or make pull requests?

Kim,
Did you see that we responded via the mailing list to your question?
Caleb Williams, on behalf of FreeCol

Post by Dong Kim
Hello FreeCol developers,
My team and I are working on contributing to an open source project as
part of our class, and we wanted to claim tickets #43 and #199 for
#199 Hotkey for move all goods: https://sourceforge.net/p/free
col/improvement-requests/199/
https://sourceforge.net/p/freecol/improvement-requests/43/
In addition, we had a few questions regarding ticket #43- which are
the relevant GUI elements that need EU pricing details on goods displayed?
We've encountered just the trade windows with the natives so far, and were
wondering how many other panels/dialogues we'd be working with, and if
there are any specific classes we should be looking at.
Please let us know at your earliest convenience. Thank you!