[Freecol-developers] Major reorganization of the Layout of DiplomaticTradeDialog.java submitted

[Caleb Williams]

Hey all,

I just submitted MR#30, my first real attempt to overhaul the layout of a
GUI/Panel file, in this case DiplomaticTradeDialog.java.

While the change isn't drastic in it's difference, there are some things
changes I feel make this panel work a little bit better.

In the existing panel, they positioning of the Tutorial text was very
problematic for me. Putting it into the first row of the Layout created a
readability issue. The main change I made is so that the Tutorial is:

1. Moved to the second row, and
2. The Tutorial cell containing the JTextArea for the Tutorial is only
displayed if there are contents to that JTextArea other than the intitial
blank value.

This can still use some refinement, but I believe it to be a step in the
right direction.

I would like to note that I believe the "meeting the foreign nation"
tutorial should eventually be broken into some type of separate dialog box,
which basically says the same thing as it does now, but before you get to
the DiplomaticTradeDialog.

Best,